incrase version number#61
Conversation
WalkthroughUpdated the Docker image tag version in the GitHub Actions workflow from Changes
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/build-gradle-project.yml (1)
47-47: Clarify the conditional logic using!=operator.The negation syntax
${{ !steps.branch-names.outputs.current_branch == 'develop' }}is ambiguous due to operator precedence. The clearer and more conventional approach is to use the not-equal operator:- - name: Push to Docker Hub if branch is not develop - if: ${{ !steps.branch-names.outputs.current_branch == 'develop' }} + - name: Push to Docker Hub if branch is not develop + if: steps.branch-names.outputs.current_branch != 'develop'
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fbdbe83d-deb2-419f-b992-aa2bf2fa8ad1
📒 Files selected for processing (1)
.github/workflows/build-gradle-project.yml
| build-gradle-project: | ||
| env: | ||
| IMAGE_TAG: 1.10.0 | ||
| IMAGE_TAG: 1.11.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check the version declared in build.gradle
# Expected: Should show version='1.10.0' (indicating mismatch with IMAGE_TAG: 1.11.0)
rg -n "version\s*=\s*['\"]" build.gradleRepository: KPMP/hydra-data
Length of output: 78
Update build.gradle version to match IMAGE_TAG: 1.11.0.
The IMAGE_TAG is being set to 1.11.0, but build.gradle still declares version='1.10.0'. This creates a mismatch where the Docker image tag will not match the artifact version inside the container. Update build.gradle to version='1.11.0' to keep them synchronized.
2 participants
Summary by CodeRabbit